From: Josh Soref <2119212+jsoref@users.noreply.github.com>
Date: Sun, 9 Nov 2025 00:50:18 +0000 (-0500)
Subject: Use map for getAppliedPolicyTypeAsString
X-Git-Tag: rec-5.4.0-alpha1~122^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d83c99fa93d88e4e98e0147943cbfa4739099323;p=thirdparty%2Fpdns.git

Use map for getAppliedPolicyTypeAsString

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
---

diff --git a/contrib/ProtobufLogger.py b/contrib/ProtobufLogger.py
index 1fea0a1cf3..23586d5aed 100644
--- a/contrib/ProtobufLogger.py
+++ b/contrib/ProtobufLogger.py
@@ -38,6 +38,15 @@ class PDNSPBConnHandler(object):
         self._oturl = oturl
         self._printjson = printjson
 
+    messageTypeToStringMap = {
+        dnsmessage_pb2.PBDNSMessage.UNKNOWN: 'Unknown',
+        dnsmessage_pb2.PBDNSMessage.QNAME: 'QName',
+        dnsmessage_pb2.PBDNSMessage.CLIENTIP: 'Client IP',
+        dnsmessage_pb2.PBDNSMessage.RESPONSEIP: 'Response IP',
+        dnsmessage_pb2.PBDNSMessage.NSDNAME: 'NS DName',
+        dnsmessage_pb2.PBDNSMessage.NSIP: 'NS IP',
+    }
+
     def run(self):
         while True:
             data = self._conn.recv(2)
@@ -150,18 +159,8 @@ class PDNSPBConnHandler(object):
 
     @staticmethod
     def getAppliedPolicyTypeAsString(polType):
-        if polType == dnsmessage_pb2.PBDNSMessage.UNKNOWN:
-            return 'Unknown'
-        elif polType == dnsmessage_pb2.PBDNSMessage.QNAME:
-            return 'QName'
-        elif polType == dnsmessage_pb2.PBDNSMessage.CLIENTIP:
-            return 'Client IP'
-        elif polType == dnsmessage_pb2.PBDNSMessage.RESPONSEIP:
-            return 'Response IP'
-        elif polType == dnsmessage_pb2.PBDNSMessage.NSDNAME:
-            return 'NS DName'
-        elif polType == dnsmessage_pb2.PBDNSMessage.NSIP:
-            return 'NS IP'
+        try:
+            return messageTypeToStringMap.get(polType, "Unrecognized")
 
     @staticmethod
     def getEventAsString(event):