From: Stephan Bosch <stephan@rename-it.nl>
Date: Thu, 30 Jun 2016 20:35:59 +0000 (+0200)
Subject: lib-http: client: Fixed potential segfault problem in http_client_connection_server_c... 
X-Git-Tag: 2.2.26~528
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d844a8843af2699fe12f1a70a942bbf4b5090295;p=thirdparty%2Fdovecot%2Fcore.git

lib-http: client: Fixed potential segfault problem in http_client_connection_server_close().

Used wrong variable: it is set to NULL by http_client_request_unref() before it is used.
Problem found by Coverity.
---

diff --git a/src/lib-http/http-client-connection.c b/src/lib-http/http-client-connection.c
index 66adf75040..567a0df375 100644
--- a/src/lib-http/http-client-connection.c
+++ b/src/lib-http/http-client-connection.c
@@ -113,7 +113,7 @@ http_client_connection_server_close(struct http_client_connection **_conn)
 		if (!http_client_request_unref(req_idx))
 			continue;
 		/* resubmit the request, which may drop it */
-		if ((*req_idx)->state < HTTP_REQUEST_STATE_FINISHED)
+		if (req->state < HTTP_REQUEST_STATE_FINISHED)
 			http_client_request_resubmit(req);
 	}	
 	array_clear(&conn->request_wait_list);