From: Tom Tromey <tromey@adacore.com>
Date: Fri, 17 Jan 2025 19:01:38 +0000 (-0700)
Subject: Simplify get_frame_unwind_table
X-Git-Tag: binutils-2_44~41
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d8c4a58b59eedbe1f77717d4e0537579232e6a10;p=thirdparty%2Fbinutils-gdb.git

Simplify get_frame_unwind_table

This simplifies get_frame_unwind_table, changing it to use the
registry 'emplace' method and to pass the initialization iterators to
the constructor.  This fixes a build problem on x86 -- reported by the
auto-builder -- as a side effect.

Tested-By: Guinevere Larsen <guinevere@redhat.com>
---

diff --git a/gdb/frame-unwind.c b/gdb/frame-unwind.c
index fab9b3c981a..33b23f91feb 100644
--- a/gdb/frame-unwind.c
+++ b/gdb/frame-unwind.c
@@ -73,15 +73,10 @@ static std::vector<const frame_unwind *> &
 get_frame_unwind_table (struct gdbarch *gdbarch)
 {
   std::vector<const frame_unwind *> *table = frame_unwind_data.get (gdbarch);
-  if (table != nullptr)
-    return *table;
-
-  table = new std::vector<const frame_unwind *>;
-  table->insert (table->begin (), standard_unwinders.begin (),
-		 standard_unwinders.end ());
-
-  frame_unwind_data.set (gdbarch, table);
-
+  if (table == nullptr)
+    table = frame_unwind_data.emplace (gdbarch,
+				       standard_unwinders.begin (),
+				       standard_unwinders.end ());
   return *table;
 }