From: Li Zefan <lizf@cn.fujitsu.com>
Date: Thu, 23 Jul 2009 03:28:40 +0000 (+0800)
Subject: trace_stack: Fix seqfile memory leak
X-Git-Tag: v2.6.31-rc5~6^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d8cc1ab793993c886c62abf77c93287df33ffd8b;p=thirdparty%2Fkernel%2Flinux.git

trace_stack: Fix seqfile memory leak

Every time we cat stack_trace, we leak memory allocated by seq_open().

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
LKML-Reference: <4A67D8E8.3020500@cn.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---

diff --git a/kernel/trace/trace_stack.c b/kernel/trace/trace_stack.c
index e644af9101246..6a2a9d484cd6b 100644
--- a/kernel/trace/trace_stack.c
+++ b/kernel/trace/trace_stack.c
@@ -301,17 +301,14 @@ static const struct seq_operations stack_trace_seq_ops = {
 
 static int stack_trace_open(struct inode *inode, struct file *file)
 {
-	int ret;
-
-	ret = seq_open(file, &stack_trace_seq_ops);
-
-	return ret;
+	return seq_open(file, &stack_trace_seq_ops);
 }
 
 static const struct file_operations stack_trace_fops = {
 	.open		= stack_trace_open,
 	.read		= seq_read,
 	.llseek		= seq_lseek,
+	.release	= seq_release,
 };
 
 int