From: Fred Morcos Date: Thu, 9 Feb 2023 16:06:58 +0000 (+0100) Subject: Whitespace X-Git-Tag: dnsdist-1.8.0-rc1~36^2~2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d8d547a83b566b04b71410c3a247c9bbe5c70cf7;p=thirdparty%2Fpdns.git Whitespace --- diff --git a/pdns/dbdnsseckeeper.cc b/pdns/dbdnsseckeeper.cc index 98b86173d7..20b51a71e6 100644 --- a/pdns/dbdnsseckeeper.cc +++ b/pdns/dbdnsseckeeper.cc @@ -58,7 +58,7 @@ bool DNSSECKeeper::doesDNSSEC() return d_keymetadb->doesDNSSEC(); } -bool DNSSECKeeper::isSecuredZone(const DNSName& zone, bool useCache) +bool DNSSECKeeper::isSecuredZone(const DNSName& zone, bool useCache) { if(isPresigned(zone, useCache)) return true; @@ -159,19 +159,19 @@ static bool keyCompareByKindAndID(const DNSSECKeeper::keyset_t::value_type& a, c } DNSSECPrivateKey DNSSECKeeper::getKeyById(const DNSName& zname, unsigned int id) -{ +{ vector keys; d_keymetadb->getDomainKeys(zname, keys); for(const DNSBackend::KeyData& kd : keys) { - if(kd.id != id) + if(kd.id != id) continue; - + DNSKEYRecordContent dkrc; auto key = shared_ptr(DNSCryptoKeyEngine::makeFromISCString(dkrc, kd.content)); DNSSECPrivateKey dpk; dpk.setKey(key, kd.flags, dkrc.d_algorithm); - - return dpk; + + return dpk; } throw runtime_error("Can't find a key with id "+std::to_string(id)+" for zone '"+zname.toLogString()+"'"); } @@ -396,10 +396,10 @@ bool DNSSECKeeper::setNSEC3PARAM(const DNSName& zname, const NSEC3PARAMRecordCon meta.push_back(descr); if (d_keymetadb->setDomainMetadata(zname, "NSEC3PARAM", meta)) { meta.clear(); - + if(narrow) meta.push_back("1"); - + return d_keymetadb->setDomainMetadata(zname, "NSEC3NARROW", meta) && clearMetaCache(zname); } return false; @@ -658,9 +658,9 @@ void DNSSECKeeper::getPreRRSIGs(UeberBackend& db, vector& rrs, ui bool DNSSECKeeper::TSIGGrantsAccess(const DNSName& zone, const DNSName& keyname) { vector allowed; - + d_keymetadb->getDomainMetadata(zone, "TSIG-ALLOW-AXFR", allowed); - + for(const string& dbkey : allowed) { if(DNSName(dbkey)==keyname) return true; @@ -673,7 +673,7 @@ bool DNSSECKeeper::getTSIGForAccess(const DNSName& zone, const ComboAddress& mas vector keynames; d_keymetadb->getDomainMetadata(zone, "AXFR-MASTER-TSIG", keynames); keyname->trimToLabels(0); - + // XXX FIXME this should check for a specific master! for(const string& dbkey : keynames) { *keyname=DNSName(dbkey); diff --git a/pdns/dnsseckeeper.hh b/pdns/dnsseckeeper.hh index 48bd0f3c6e..e753e8e746 100644 --- a/pdns/dnsseckeeper.hh +++ b/pdns/dnsseckeeper.hh @@ -171,13 +171,13 @@ private: public: DNSSECKeeper() : d_keymetadb( new UeberBackend("key-only")), d_ourDB(true) { - + } - + DNSSECKeeper(UeberBackend* db) : d_keymetadb(db), d_ourDB(false) { } - + ~DNSSECKeeper() { if(d_ourDB) @@ -221,17 +221,17 @@ public: bool TSIGGrantsAccess(const DNSName& zone, const DNSName& keyname); bool getTSIGForAccess(const DNSName& zone, const ComboAddress& master, DNSName* keyname); - + void startTransaction(const DNSName& zone, int zone_id) { (*d_keymetadb->backends.begin())->startTransaction(zone, zone_id); } - + void commitTransaction() { (*d_keymetadb->backends.begin())->commitTransaction(); } - + void getFromMetaOrDefault(const DNSName& zname, const std::string& key, std::string& value, const std::string& defaultvalue); bool getFromMeta(const DNSName& zname, const std::string& key, std::string& value); void getSoaEdit(const DNSName& zname, std::string& value, bool useCache=true); @@ -250,17 +250,17 @@ private: struct KeyCacheEntry { typedef vector keys_t; - + uint32_t isStale(time_t now) const { return d_ttd < now; } - + DNSName d_domain; mutable keys_t d_keys; unsigned int d_ttd; }; - + struct METACacheEntry { time_t isStale(time_t now) const @@ -272,11 +272,11 @@ private: mutable METAValues d_value; time_t d_ttd; }; - + struct KeyCacheTag{}; struct CompositeTag{}; struct SequencedTag{}; - + typedef multi_index_container< KeyCacheEntry, indexed_by<