From: Renaud Métrich <rmetrich@redhat.com>
Date: Mon, 1 Mar 2021 16:43:10 +0000 (+0100)
Subject: fix(dracut.sh): harden dracut against GZIP environment variable
X-Git-Tag: 054~340
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d8e47e201af4646e2a82e11220ea9c993bd2ed48;p=thirdparty%2Fdracut.git

fix(dracut.sh): harden dracut against GZIP environment variable

When a GZIP environment variable is set, this leads to various breakage:

In case 'pigz' is installed and GZIP is defined as a path, e.g.
/usr/local/bin/gzip, then dracut will fail with the following message:

   "
   pigz: abort: cannot provide files in GZIP environment variable
   "

In case 'pigz' isn't installed and regular 'gzip' is used and GZIP is
defined as a path, e.g. /usr/local/bin/gzip, then the path will be
zipped and dracut will fail for no obvious reason.  Trying again, dracut
will then fail with following message:

   "
   gzip: /usr/local/bin/gzip.gz already exists;	not overwritten
   "

In any case, GZIP environment should be unset to avoid breakage or
unwanted behaviour. This variable is anyway obsolescent, from gzip(1)
manpage.

Signed-off-by: Renaud Métrich <rmetrich@redhat.com>
---

diff --git a/dracut.sh b/dracut.sh
index 062ed6c1a..836b762c6 100755
--- a/dracut.sh
+++ b/dracut.sh
@@ -24,6 +24,7 @@
 # store for logging
 
 unset BASH_ENV
+unset GZIP
 
 # Verify bash version, current minimum is 4
 if (( BASH_VERSINFO[0] < 4 )); then