From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Tue, 5 Sep 2023 02:17:36 +0000 (+1200)
Subject: s4:kdc: Be sure not to pass a NULL pointer into strcmp()
X-Git-Tag: tevent-0.16.0~580
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d902c134d72d47ca92a3b71e1dc99d22d2ab5dbd;p=thirdparty%2Fsamba.git

s4:kdc: Be sure not to pass a NULL pointer into strcmp()

To do so is to invoke undefined behaviour.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/kdc/db-glue.c b/source4/kdc/db-glue.c
index 3821815d0dd..c97cfdf47cb 100644
--- a/source4/kdc/db-glue.c
+++ b/source4/kdc/db-glue.c
@@ -696,7 +696,9 @@ krb5_error_code samba_kdc_message2entry_keys(krb5_context context,
 		}
 
 		for (i=0; i < scb.sub.num_packages; i++) {
-			if (strcmp("Primary:Kerberos-Newer-Keys", scb.sub.packages[i].name) == 0) {
+			if (scb.sub.packages[i].name != NULL &&
+			    strcmp("Primary:Kerberos-Newer-Keys", scb.sub.packages[i].name) == 0)
+			{
 				scpk = &scb.sub.packages[i];
 				if (!scpk->data || !scpk->data[0]) {
 					scpk = NULL;