From: Jakub Jelinek Date: Wed, 9 Nov 2022 12:07:32 +0000 (+0100) Subject: Fix up foperator_abs::op1_range [PR107569] X-Git-Tag: basepoints/gcc-14~3355 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d943927ff860cea44a9cf64fc6d591a4a6e37f6f;p=thirdparty%2Fgcc.git Fix up foperator_abs::op1_range [PR107569] foperator_abs::op1_range works except for the NaN handling, from: [frange] double [-Inf, 1.79769313486231570814527423731704356798070567525844996599e+308 (0x0.fffffffffffff8p+1024)] lhs it computes r [frange] double [-1.79769313486231570814527423731704356798070567525844996599e+308 (-0x0.fffffffffffff8p+1024), 1.79769313486231570814527423731704356798070567525844996599e+308 +(0x0.fffffffffffff8p+1024)] +-NAN which is correct except for the +-NAN part. For r before the final step it makes sure to add -NAN if there is +NAN in the lhs range, but the final r.union_ makes it unconditional +-NAN, because the frange ctor sets +-NAN. So, I think we need to clear it (or have some set variant which says not to set NAN). This patch fixes that, but isn't enough to fix the PR, something in the assumptions handling is still broken (and the PR has other parts). 2022-11-09 Jakub Jelinek PR tree-optimization/107569 * range-op-float.cc (foperator_abs::op1_range): Clear NaNs from the negatives frange before unioning it into r. --- diff --git a/gcc/range-op-float.cc b/gcc/range-op-float.cc index 44db81c1c1ec..cc806438a198 100644 --- a/gcc/range-op-float.cc +++ b/gcc/range-op-float.cc @@ -1394,9 +1394,10 @@ foperator_abs::op1_range (frange &r, tree type, return true; // Then add the negative of each pair: // ABS(op1) = [5,20] would yield op1 => [-20,-5][5,20]. - r.union_ (frange (type, - real_value_negate (&positives.upper_bound ()), - real_value_negate (&positives.lower_bound ()))); + frange negatives (type, real_value_negate (&positives.upper_bound ()), + real_value_negate (&positives.lower_bound ())); + negatives.clear_nan (); + r.union_ (negatives); return true; }