From: Greg Kroah-Hartman Date: Tue, 17 Sep 2019 18:31:30 +0000 (+0200) Subject: 4.9-stable patches X-Git-Tag: v4.14.145~7 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d950add414ea85d99e27a063a626e35ff26090aa;p=thirdparty%2Fkernel%2Fstable-queue.git 4.9-stable patches added patches: x86-build-add-wnoaddress-of-packed-member-to-realmode_cflags-to-silence-gcc9-build-warning.patch --- diff --git a/queue-4.9/series b/queue-4.9/series index 57cb7f04531..a3a4b4425dd 100644 --- a/queue-4.9/series +++ b/queue-4.9/series @@ -31,3 +31,4 @@ crypto-talitos-do-not-modify-req-cryptlen-on-decryption.patch crypto-talitos-hmac-snoop-no-afeu-mode-requires-sw-icv-checking.patch drm-mediatek-mtk_drm_drv.c-add-of_node_put-before-goto.patch nvmem-use-the-same-permissions-for-eeprom-as-for-nvmem.patch +x86-build-add-wnoaddress-of-packed-member-to-realmode_cflags-to-silence-gcc9-build-warning.patch diff --git a/queue-4.9/x86-build-add-wnoaddress-of-packed-member-to-realmode_cflags-to-silence-gcc9-build-warning.patch b/queue-4.9/x86-build-add-wnoaddress-of-packed-member-to-realmode_cflags-to-silence-gcc9-build-warning.patch new file mode 100644 index 00000000000..dca17c7b667 --- /dev/null +++ b/queue-4.9/x86-build-add-wnoaddress-of-packed-member-to-realmode_cflags-to-silence-gcc9-build-warning.patch @@ -0,0 +1,52 @@ +From 42e0e95474fc6076b5cd68cab8fa0340a1797a72 Mon Sep 17 00:00:00 2001 +From: Linus Torvalds +Date: Wed, 28 Aug 2019 10:56:48 +0200 +Subject: x86/build: Add -Wnoaddress-of-packed-member to REALMODE_CFLAGS, to silence GCC9 build warning +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Linus Torvalds + +commit 42e0e95474fc6076b5cd68cab8fa0340a1797a72 upstream. + +One of the very few warnings I have in the current build comes from +arch/x86/boot/edd.c, where I get the following with a gcc9 build: + + arch/x86/boot/edd.c: In function ‘query_edd’: + arch/x86/boot/edd.c:148:11: warning: taking address of packed member of ‘struct boot_params’ may result in an unaligned pointer value [-Waddress-of-packed-member] + 148 | mbrptr = boot_params.edd_mbr_sig_buffer; + | ^~~~~~~~~~~ + +This warning triggers because we throw away all the CFLAGS and then make +a new set for REALMODE_CFLAGS, so the -Wno-address-of-packed-member we +added in the following commit is not present: + + 6f303d60534c ("gcc-9: silence 'address-of-packed-member' warning") + +The simplest solution for now is to adjust the warning for this version +of CFLAGS as well, but it would definitely make sense to examine whether +REALMODE_CFLAGS could be derived from CFLAGS, so that it picks up changes +in the compiler flags environment automatically. + +Signed-off-by: Linus Torvalds +Acked-by: Borislav Petkov +Cc: Peter Zijlstra +Cc: Thomas Gleixner +Signed-off-by: Ingo Molnar +Signed-off-by: Greg Kroah-Hartman + +--- + arch/x86/Makefile | 1 + + 1 file changed, 1 insertion(+) + +--- a/arch/x86/Makefile ++++ b/arch/x86/Makefile +@@ -38,6 +38,7 @@ REALMODE_CFLAGS := $(M16_CFLAGS) -g -Os + + REALMODE_CFLAGS += $(call __cc-option, $(CC), $(REALMODE_CFLAGS), -ffreestanding) + REALMODE_CFLAGS += $(call __cc-option, $(CC), $(REALMODE_CFLAGS), -fno-stack-protector) ++REALMODE_CFLAGS += $(call __cc-option, $(CC), $(REALMODE_CFLAGS), -Wno-address-of-packed-member) + REALMODE_CFLAGS += $(call __cc-option, $(CC), $(REALMODE_CFLAGS), $(cc_stack_align4)) + export REALMODE_CFLAGS +