From: Junio C Hamano Date: Fri, 9 Oct 2020 18:56:52 +0000 (-0700) Subject: SubmittingPatches: clarify the purpose of the final resend X-Git-Tag: v2.30.0-rc0~117^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d95b192efda2c437d7a44f15db6d9b9f6ac1b5f9;p=thirdparty%2Fgit.git SubmittingPatches: clarify the purpose of the final resend Signed-off-by: Junio C Hamano --- diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 291b61e262..87089654ae 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -290,12 +290,14 @@ identify them), to solicit comments and reviews. :git-ml: footnote:[The mailing list: git@vger.kernel.org] After the list reached a consensus that it is a good idea to apply the -patch, re-send it with "To:" set to the maintainer{current-maintainer} and "cc:" the -list{git-ml} for inclusion. +patch, re-send it with "To:" set to the maintainer{current-maintainer} +and "cc:" the list{git-ml} for inclusion. This is especially relevant +when the maintainer did not heavily participate in the discussion and +instead left the review to trusted others. Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and `Tested-by:` lines as necessary to credit people who helped your -patch. +patch, and "cc:" them when sending such a final version for inclusion. [[sign-off]] === Certify your work by adding your "Signed-off-by: " line