From: Greg Kroah-Hartman Date: Sat, 28 Jul 2018 06:50:53 +0000 (+0200) Subject: 4.4-stable patches X-Git-Tag: v4.17.12~35 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d9631937a11cf9a45b612c1a3eaabdd9f2088178;p=thirdparty%2Fkernel%2Fstable-queue.git 4.4-stable patches added patches: mips-fix-off-by-one-in-pci_resource_to_user.patch --- diff --git a/queue-4.4/mips-fix-off-by-one-in-pci_resource_to_user.patch b/queue-4.4/mips-fix-off-by-one-in-pci_resource_to_user.patch new file mode 100644 index 00000000000..bf67143644e --- /dev/null +++ b/queue-4.4/mips-fix-off-by-one-in-pci_resource_to_user.patch @@ -0,0 +1,49 @@ +From 38c0a74fe06da3be133cae3fb7bde6a9438e698b Mon Sep 17 00:00:00 2001 +From: Paul Burton +Date: Thu, 12 Jul 2018 09:33:04 -0700 +Subject: MIPS: Fix off-by-one in pci_resource_to_user() + +From: Paul Burton + +commit 38c0a74fe06da3be133cae3fb7bde6a9438e698b upstream. + +The MIPS implementation of pci_resource_to_user() introduced in v3.12 by +commit 4c2924b725fb ("MIPS: PCI: Use pci_resource_to_user to map pci +memory space properly") incorrectly sets *end to the address of the +byte after the resource, rather than the last byte of the resource. + +This results in userland seeing resources as a byte larger than they +actually are, for example a 32 byte BAR will be reported by a tool such +as lspci as being 33 bytes in size: + + Region 2: I/O ports at 1000 [disabled] [size=33] + +Correct this by subtracting one from the calculated end address, +reporting the correct address to userland. + +Signed-off-by: Paul Burton +Reported-by: Rui Wang +Fixes: 4c2924b725fb ("MIPS: PCI: Use pci_resource_to_user to map pci memory space properly") +Cc: James Hogan +Cc: Ralf Baechle +Cc: Wolfgang Grandegger +Cc: linux-mips@linux-mips.org +Cc: stable@vger.kernel.org # v3.12+ +Patchwork: https://patchwork.linux-mips.org/patch/19829/ +Signed-off-by: Greg Kroah-Hartman + +--- + arch/mips/include/asm/pci.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +--- a/arch/mips/include/asm/pci.h ++++ b/arch/mips/include/asm/pci.h +@@ -89,7 +89,7 @@ static inline void pci_resource_to_user( + phys_addr_t size = resource_size(rsrc); + + *start = fixup_bigphys_addr(rsrc->start, size); +- *end = rsrc->start + size; ++ *end = rsrc->start + size - 1; + } + + /*