From: Florian Fainelli Date: Thu, 10 May 2018 20:17:30 +0000 (-0700) Subject: net: phy: phylink: Release link GPIO X-Git-Tag: v4.18-rc1~114^2~267^2~7 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=daab3349ad1a69663ccad278ed71d55974d104b4;p=thirdparty%2Fkernel%2Flinux.git net: phy: phylink: Release link GPIO We are not releasing the link GPIO descriptor with gpiod_put() which results in subsequent probing to get -EBUSY when calling fwnode_get_named_gpiod(). Fix this by doing the release in phylink_destroy(). Fixes: 9525ae83959b ("phylink: add phylink infrastructure") Signed-off-by: Florian Fainelli Signed-off-by: David S. Miller --- diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 412d1cf4fa663..6392b5248cf54 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -612,6 +612,8 @@ void phylink_destroy(struct phylink *pl) { if (pl->sfp_bus) sfp_unregister_upstream(pl->sfp_bus); + if (!IS_ERR(pl->link_gpio)) + gpiod_put(pl->link_gpio); cancel_work_sync(&pl->resolve); kfree(pl);