From: Ricardo Costa <ricardocosta89@users.noreply.github.com>
Date: Sun, 28 May 2017 21:23:20 +0000 (+0100)
Subject: Fix onHover event not being triggered (#4297)
X-Git-Tag: v2.7.0~1^2~104
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=dab0a7f699f18cf73bd2af19760bbe0b4d0d703c;p=thirdparty%2FChart.js.git

Fix onHover event not being triggered (#4297)

Fix onHover event not being triggered

The core controller was looking at the wrong object (options.hover) to
find the function to be called on hover. The function is provided on the
top level options object (options.onHover).

By using the helper function, there's no need to verify if the callback
is defined, as the helper already does that.

Fixes #4296
---

diff --git a/src/core/core.controller.js b/src/core/core.controller.js
index 71eb3bb62..f8c471f3d 100644
--- a/src/core/core.controller.js
+++ b/src/core/core.controller.js
@@ -808,11 +808,9 @@ module.exports = function(Chart) {
 				me.active = me.getElementsAtEventForMode(e, hoverOptions.mode, hoverOptions);
 			}
 
-			// On Hover hook
-			if (hoverOptions.onHover) {
-				// Need to call with native event here to not break backwards compatibility
-				hoverOptions.onHover.call(me, e.native, me.active);
-			}
+			// Invoke onHover hook
+			// Need to call with native event here to not break backwards compatibility
+			helpers.callback(options.onHover || options.hover.onHover, [e.native, me.active], me);
 
 			if (e.type === 'mouseup' || e.type === 'click') {
 				if (options.onClick) {