From: Michael Tremer <michael.tremer@ipfire.org>
Date: Tue, 7 Jan 2020 13:45:21 +0000 (+0000)
Subject: dns.cgi: Timeout after 2 seconds for DNS server checks
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=dab1258a789ab3c09b6766e603bbdbab57010909;p=people%2Fstevee%2Fipfire-2.x.git

dns.cgi: Timeout after 2 seconds for DNS server checks

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/html/cgi-bin/dns.cgi b/html/cgi-bin/dns.cgi
index 23e4a71def..42fd8002aa 100755
--- a/html/cgi-bin/dns.cgi
+++ b/html/cgi-bin/dns.cgi
@@ -759,12 +759,8 @@ sub grab_address_from_file($) {
 sub check_nameserver($$$$) {
 	my ($nameserver, $record, $proto, $tls_hostname) = @_;
 
-	# Timout for the query in seconds.
-	my $timeout;
-	my $retry = "+retry=0";
-
 	# Default values.
-	my @command = ("kdig", "$timeout", "$retry", "+dnssec",
+	my @command = ("kdig", "+timeout=2", "+retry=0", "+dnssec",
 		"+bufsize=1232");
 
 	# Handle different protols.