From: Ulrich Drepper <drepper@redhat.com>
Date: Wed, 21 Jan 2009 21:05:36 +0000 (-0800)
Subject: Fix elflint test for .eh_frame_hdr allocation.
X-Git-Tag: elfutils-0.139~16
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=daf0fda7c0e6dcdcc6d011c89a7c6e94ecd238e1;p=thirdparty%2Felfutils.git

Fix elflint test for .eh_frame_hdr allocation.
---

diff --git a/src/ChangeLog b/src/ChangeLog
index 9a0774d0e..9814eb8cc 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,9 @@
+2009-01-21  Ulrich Drepper  <drepper@redhat.com>
+
+	* elflint.c (check_program_header): Fix typo in .eh_frame_hdr section
+	test.
+	(check_exception_data): First sanity test.
+
 2009-01-17  Ulrich Drepper  <drepper@redhat.com>
 
 	* readelf.c (print_debug_exception_table): Show target of ar_disp
diff --git a/src/elflint.c b/src/elflint.c
index f31b75c1f..3beac4646 100644
--- a/src/elflint.c
+++ b/src/elflint.c
@@ -4223,7 +4223,7 @@ call frame search table size mismatch in program and section header\n"));
 	  if ((phdr->p_flags & PF_R) == 0)
 	    ERROR (gettext ("\
 call frame search table must be allocated\n"));
-	  else if (shdr != NULL && (shdr->sh_flags & SHF_ALLOC) != 0)
+	  else if (shdr != NULL && (shdr->sh_flags & SHF_ALLOC) == 0)
 	    ERROR (gettext ("\
 section [%2zu] '%s' must be allocated\n"), elf_ndxscn (scn), ".eh_frame_hdr");
 
@@ -4270,6 +4270,10 @@ static void
 check_exception_data (Ebl *ebl __attribute__ ((unused)),
 		      GElf_Ehdr *ehdr __attribute__ ((unused)))
 {
+  if ((ehdr->e_type == ET_EXEC || ehdr->e_type == ET_DYN)
+      && pt_gnu_eh_frame_pndx == 0 && eh_frame_hdr_scnndx != 0)
+    ERROR (gettext ("executable/DSO with .eh_frame_hdr section does not have "
+		    "a PT_GNU_EH_FRAME program header entry"));
 }