From: Pedro Tammela <pctammela@mojatatu.com>
Date: Fri, 28 Jul 2023 15:35:34 +0000 (-0300)
Subject: net/sched: sch_drr: warn about class in use while deleting
X-Git-Tag: v6.6-rc1~162^2~276^2~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=daf8d9181b9b4b58d3b182d1fea10dec75c5de88;p=thirdparty%2Fkernel%2Flinux.git

net/sched: sch_drr: warn about class in use while deleting

Add extack to warn that delete was rejected because
the class is still in use

Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---

diff --git a/net/sched/sch_drr.c b/net/sched/sch_drr.c
index 1b22b3b741c9a..19901e77cd3b7 100644
--- a/net/sched/sch_drr.c
+++ b/net/sched/sch_drr.c
@@ -149,8 +149,10 @@ static int drr_delete_class(struct Qdisc *sch, unsigned long arg,
 	struct drr_sched *q = qdisc_priv(sch);
 	struct drr_class *cl = (struct drr_class *)arg;
 
-	if (qdisc_class_in_use(&cl->common))
+	if (qdisc_class_in_use(&cl->common)) {
+		NL_SET_ERR_MSG(extack, "DRR class is in use");
 		return -EBUSY;
+	}
 
 	sch_tree_lock(sch);