From: Aki Tuomi <aki.tuomi@open-xchange.com>
Date: Thu, 21 Apr 2022 10:43:09 +0000 (+0300)
Subject: lib: net - Set ip before port in net_listen_full()
X-Git-Tag: 2.4.0~4114
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=db51bb77688009ba24a66076407a68898c1ccab7;p=thirdparty%2Fdovecot%2Fcore.git

lib: net - Set ip before port in net_listen_full()

sin_set_ip() sets address family which is required in sin_set_port().

In linux, sin_port and sin6_port are in same place of the sockaddr union,
so previous use did not break anything.
---

diff --git a/src/lib/net.c b/src/lib/net.c
index 1eb04ffd76..d960d81fa1 100644
--- a/src/lib/net.c
+++ b/src/lib/net.c
@@ -468,8 +468,8 @@ int net_listen_full(const struct ip_addr *my_ip, in_port_t *port,
 	socklen_t len;
 
 	i_zero(&so);
-	sin_set_port(&so, *port);
 	sin_set_ip(&so, my_ip);
+	sin_set_port(&so, *port);
 
 	/* create the socket */
 	fd = socket(so.sin.sin_family, SOCK_STREAM, 0);