From: Joseph Myers <joseph@codesourcery.com>
Date: Thu, 13 Dec 2018 22:36:33 +0000 (+0000)
Subject: Do not clobber sp in _hurd_stack_setup.
X-Git-Tag: glibc-2.29~201
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=db6df070cfff9ba78a72346208859b3fdee09561;p=thirdparty%2Fglibc.git

Do not clobber sp in _hurd_stack_setup.

GCC mainline now gives errors for an asm that clobbers the stack
pointer.  According to
<https://gcc.gnu.org/ml/gcc-patches/2018-12/msg00932.html> GCC
previously ignored such a clobber; thus, this patch removes it from
_hurd_stack_setup.

Tested with build-many-glibcs.py for i686-gnu.

	* sysdeps/mach/hurd/i386/init-first.c (_hurd_stack_setup): Do not
	clobber sp.
---

diff --git a/ChangeLog b/ChangeLog
index e457d581e90..e419448fe6b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2018-12-13  Joseph Myers  <joseph@codesourcery.com>
+
+	* sysdeps/mach/hurd/i386/init-first.c (_hurd_stack_setup): Do not
+	clobber sp.
+
 2018-12-13  fanjinke  <fanjinke@hygon.cn>
 
 	* sysdeps/x86/cpu-features.c (init_cpu_features): Check for
diff --git a/sysdeps/mach/hurd/i386/init-first.c b/sysdeps/mach/hurd/i386/init-first.c
index f8ad2ceb8e3..e3d57972666 100644
--- a/sysdeps/mach/hurd/i386/init-first.c
+++ b/sysdeps/mach/hurd/i386/init-first.c
@@ -361,7 +361,7 @@ _hurd_stack_setup (void)
       *--data = caller;
       asm volatile ("movl %0, %%esp\n" /* Switch to new outermost stack.  */
 		    "movl $0, %%ebp\n" /* Clear outermost frame pointer.  */
-		    "jmp *%1" : : "r" (data), "r" (&doinit1) : "sp");
+		    "jmp *%1" : : "r" (data), "r" (&doinit1));
       /* NOTREACHED */
     }