From: Jim Meyering <jim@meyering.net>
Date: Wed, 31 Aug 2005 07:51:04 +0000 (+0000)
Subject: (quotearg_n_options): Change code to be suboptimal, in
X-Git-Tag: CPPI-1_12~60
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=db875eadae0498da50f8dc5e4d8203d220722752;p=thirdparty%2Fcoreutils.git

(quotearg_n_options): Change code to be suboptimal, in
order to avoid an unsuppressible warning from gcc on 64-bit systems.
---

diff --git a/lib/quotearg.c b/lib/quotearg.c
index 13fcf0b516..a66f882b0b 100644
--- a/lib/quotearg.c
+++ b/lib/quotearg.c
@@ -1,6 +1,6 @@
 /* quotearg.c - quote arguments for output
 
-   Copyright (C) 1998, 1999, 2000, 2001, 2002, 2004 Free Software
+   Copyright (C) 1998, 1999, 2000, 2001, 2002, 2004, 2005 Free Software
    Foundation, Inc.
 
    This program is free software; you can redistribute it and/or modify
@@ -581,7 +581,12 @@ quotearg_n_options (int n, char const *arg, size_t argsize,
 
   if (nslots <= n0)
     {
-      unsigned int n1 = n0 + 1;
+      /* FIXME: technically, the type of n1 should be `unsigned int',
+	 but that evokes an unsuppressible warning from gcc-4.0.1 and
+	 older.  If gcc ever provides an option to suppress that warning,
+	 revert to the original type, so that the test in xalloc_oversized
+	 is once again performed only at compile time.  */
+      size_t n1 = n0 + 1;
 
       if (xalloc_oversized (n1, sizeof *slotvec))
 	xalloc_die ();