From: Gao Xiang <hsiangkao@linux.alibaba.com>
Date: Tue, 14 Jan 2025 04:00:58 +0000 (+0800)
Subject: erofs: fix potential return value overflow of z_erofs_shrink_scan()
X-Git-Tag: v6.14-rc1~86^2~7
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=db902986dee453bfb5835cbc8efa67154ab34caf;p=thirdparty%2Fkernel%2Flinux.git

erofs: fix potential return value overflow of z_erofs_shrink_scan()

z_erofs_shrink_scan() could return small numbers due to the mistyped
`freed`.

Although I don't think it has any visible impact.

Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support")
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Link: https://lore.kernel.org/r/20250114040058.459981-1-hsiangkao@linux.alibaba.com
---

diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
index 19ef4ff2a1345..f416b73e0ca31 100644
--- a/fs/erofs/zdata.c
+++ b/fs/erofs/zdata.c
@@ -927,8 +927,7 @@ unsigned long z_erofs_shrink_scan(struct erofs_sb_info *sbi,
 				  unsigned long nr_shrink)
 {
 	struct z_erofs_pcluster *pcl;
-	unsigned int freed = 0;
-	unsigned long index;
+	unsigned long index, freed = 0;
 
 	xa_lock(&sbi->managed_pslots);
 	xa_for_each(&sbi->managed_pslots, index, pcl) {