From: Willy Tarreau <w@1wt.eu>
Date: Tue, 8 Aug 2023 13:27:02 +0000 (+0200)
Subject: MINOR: mux-h2/traces: also suggest invalid header upon parsing error
X-Git-Tag: v2.9-dev3~54
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=db97bb42d9b435846809a028dce077eea1621b40;p=thirdparty%2Fhaproxy.git

MINOR: mux-h2/traces: also suggest invalid header upon parsing error

Historically the parsing error used to apply only to too large headers,
so this is what has been reported in traces. But nowadays we can also
reject invalid characters, and when this happens the trace is a bit
misleading, so let's mention "or invalid".
---

diff --git a/src/mux_h2.c b/src/mux_h2.c
index 4120e00405..63b9a805c1 100644
--- a/src/mux_h2.c
+++ b/src/mux_h2.c
@@ -4940,7 +4940,7 @@ next_frame:
 
 	if (outlen < 0 || htx_free_space(htx) < global.tune.maxrewrite) {
 		/* too large headers? this is a stream error only */
-		TRACE_STATE("message headers too large", H2_EV_RX_FRAME|H2_EV_RX_HDR|H2_EV_H2S_ERR|H2_EV_PROTO_ERR, h2c->conn);
+		TRACE_STATE("message headers too large or invalid", H2_EV_RX_FRAME|H2_EV_RX_HDR|H2_EV_H2S_ERR|H2_EV_PROTO_ERR, h2c->conn);
 		htx->flags |= HTX_FL_PARSING_ERROR;
 		goto fail;
 	}