From: Xiaogang Chen Date: Tue, 12 Jan 2021 06:36:52 +0000 (+0000) Subject: drm: distinguish return value of drm_dp_check_and_send_link_address X-Git-Tag: v5.12-rc1~132^2~14^2~84 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=dc25e3776e8f50ff833803ad361ec709dc78f4f9;p=thirdparty%2Flinux.git drm: distinguish return value of drm_dp_check_and_send_link_address drm_dp_check_and_send_link_address discovers MST device topology. It can return both positive and negative values. When it returns positive values there is no error found. If it returns negative values there is error found, such as get NAK , timeout, etc. Following drm_kms_helper_hotplug_event should be called when drm_dp_check_and_send_link_address returns positive value. Signed-off-by: Xiaogang Chen Acked-by: Simon Ser Signed-off-by: Simon Ser (re-formatted commit message) Link: https://patchwork.freedesktop.org/patch/msgid/DM6PR12MB2602B6281BF8C9430115E03BE3AA0@DM6PR12MB2602.namprd12.prod.outlook.com --- diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 0401b2f475002..18b15a4aee2da 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_dp_mst_topology.c @@ -2751,7 +2751,7 @@ static void drm_dp_mst_link_probe_work(struct work_struct *work) drm_dp_mst_topology_put_mstb(mstb); mutex_unlock(&mgr->probe_lock); - if (ret) + if (ret > 0) drm_kms_helper_hotplug_event(dev); }