From: Michael Tremer <michael.tremer@ipfire.org>
Date: Fri, 9 Jun 2023 07:51:50 +0000 (+0000)
Subject: networkctl: Terminate after showing help or version
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=dc2a5320b848576772c261b76b23b87715d118a7;p=network.git

networkctl: Terminate after showing help or version

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/networkctl/main.c b/src/networkctl/main.c
index 0ba72849..fde77b82 100644
--- a/src/networkctl/main.c
+++ b/src/networkctl/main.c
@@ -21,6 +21,7 @@
 #include <errno.h>
 #include <getopt.h>
 #include <stdio.h>
+#include <stdlib.h>
 #include <unistd.h>
 
 #include <systemd/sd-bus.h>
@@ -45,13 +46,13 @@ static int networkctl_main(sd_bus* bus, int argc, char* argv[]) {
 	return command_dispatch(bus, commands, argc, argv);
 }
 
-static int version(void) {
+static void version(void) {
 	printf("networkctl %s\n", PACKAGE_VERSION);
 
-	return 0;
+	exit(0);
 }
 
-static int help(void) {
+static void help(void) {
 	printf(
 		"%s [OPTIONS...] COMMAND\n\n"
 		"Options:\n"
@@ -60,7 +61,7 @@ static int help(void) {
 		program_invocation_short_name
 	);
 
-	return 0;
+	exit(0);
 }
 
 static int parse_argv(int argc, char* argv[]) {
@@ -82,10 +83,10 @@ static int parse_argv(int argc, char* argv[]) {
 
 		switch (c) {
 			case 'h':
-				return help();
+				help();
 
 			case ARG_VERSION:
-				return version();
+				version();
 
 			case '?':
 				return -EINVAL;