From: Darrick J. Wong Date: Mon, 29 Jul 2024 23:23:16 +0000 (-0700) Subject: xfs_scrub_all: remove journalctl background process X-Git-Tag: v6.10.0~11^2~4 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=dc332e467413ec9160668e822429333cb0736da7;p=thirdparty%2Fxfsprogs-dev.git xfs_scrub_all: remove journalctl background process Now that we only start systemd services if we're running in service mode, there's no need for the background journalctl process that only ran if we had started systemd services in non-service mode. Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig --- diff --git a/scrub/xfs_scrub_all.in b/scrub/xfs_scrub_all.in index f27251fa..fc7a2e63 100644 --- a/scrub/xfs_scrub_all.in +++ b/scrub/xfs_scrub_all.in @@ -261,17 +261,6 @@ def main(): fs = find_mounts() - # Tail the journal if we ourselves aren't a service... - journalthread = None - if 'SERVICE_MODE' not in os.environ: - try: - cmd=['journalctl', '--no-pager', '-q', '-S', 'now', \ - '-f', '-u', 'xfs_scrub@*', '-o', \ - 'cat'] - journalthread = subprocess.Popen(cmd) - except: - pass - # Schedule scrub jobs... running_devs = set() killfuncs = set() @@ -308,9 +297,6 @@ def main(): while len(killfuncs) > 0: wait_for_termination(cond, killfuncs) - if journalthread is not None: - journalthread.terminate() - # See the service mode comments in xfs_scrub.c for why we do this. if 'SERVICE_MODE' in os.environ: time.sleep(2)