From: Andrew Goodbody <andrew.goodbody@linaro.org>
Date: Fri, 8 Aug 2025 10:29:33 +0000 (+0100)
Subject: drivers: qe: avoid double free()
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=dc37adfc040877db359abdc7eab19adffb8fc722;p=thirdparty%2Fu-boot.git

drivers: qe: avoid double free()

Avoid calling free(addr) twice if the device for ucode is not found.
This patch repeats a similar fix but that only applied to code without
CONFIG_TFABOOT enabled. This patch applies to the code with
CONFIG_TFABOOT enabled.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---

diff --git a/drivers/qe/qe.c b/drivers/qe/qe.c
index 69b7de084e5..25880db37cf 100644
--- a/drivers/qe/qe.c
+++ b/drivers/qe/qe.c
@@ -255,7 +255,6 @@ void u_qe_init(void)
 		struct mmc *mmc = find_mmc_device(CONFIG_ENV_MMC_DEVICE_INDEX);
 
 		if (!mmc) {
-			free(addr);
 			printf("\nMMC cannot find device for ucode\n");
 		} else {
 			printf("\nMMC read: dev # %u, block # %u, count %u ...\n",