From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 26 Mar 2025 15:25:47 +0000 (-0400)
Subject: coredump: make sure we initialize all return parameters on success of save_external_c... 
X-Git-Tag: v258-rc1~1003^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=dc8e3118f9ff269157bd0e3ddf25df1e65f0f874;p=thirdparty%2Fsystemd.git

coredump: make sure we initialize all return parameters on success of save_external_coredump()
---

diff --git a/src/coredump/coredump.c b/src/coredump/coredump.c
index cd1adfb9cd2..3f6eecbcfab 100644
--- a/src/coredump/coredump.c
+++ b/src/coredump/coredump.c
@@ -615,9 +615,9 @@ static int save_external_coredump(
 
                 *ret_filename = TAKE_PTR(fn_compressed);       /* compressed */
                 *ret_node_fd = TAKE_FD(fd_compressed);         /* compressed */
-                *ret_compressed_size = (uint64_t) st.st_size;  /* compressed */
                 *ret_data_fd = TAKE_FD(fd);
                 *ret_size = uncompressed_size;
+                *ret_compressed_size = (uint64_t) st.st_size;  /* compressed */
                 *ret_truncated = truncated;
                 tmp_compressed = mfree(tmp_compressed);
 
@@ -642,8 +642,10 @@ static int save_external_coredump(
                 return log_error_errno(errno, "Failed to seek on coredump %s: %m", fn);
 
         *ret_filename = TAKE_PTR(fn);
+        *ret_node_fd = -EBADF;
         *ret_data_fd = TAKE_FD(fd);
         *ret_size = (uint64_t) st.st_size;
+        *ret_compressed_size = UINT64_MAX;
         *ret_truncated = truncated;
 
         return 0;