From: Tankut Baris Aktemur Date: Wed, 29 Jan 2025 09:50:29 +0000 (+0100) Subject: gdbserver: add back lost comments in fast_tracepoint_ctx X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=dcaf6d3f431d95dabcd27c54b7e9fb51989e3b23;p=thirdparty%2Fbinutils-gdb.git gdbserver: add back lost comments in fast_tracepoint_ctx Before the removal of the UST/static-tracepoint support, the `static_tracepoint_ctx` struct contained comments for its fields, whereas `fast_tracepoint_ctx` did not. Nevertheless, those comments also applied to `fast_tracepoint_ctx`. With the removal of `static_tracepoint_ctx`, the comments were lost, making `fast_tracepoint_ctx` data members completely commentless. Add back those comments. Approved-By: Simon Marchi --- diff --git a/gdbserver/tracepoint.cc b/gdbserver/tracepoint.cc index 1395c70ad39..559d34dc3e2 100644 --- a/gdbserver/tracepoint.cc +++ b/gdbserver/tracepoint.cc @@ -1184,11 +1184,20 @@ struct fast_tracepoint_ctx { struct tracepoint_hit_ctx base; + /* The regcache corresponding to the registers state at the time of + the tracepoint hit. Initialized lazily, from REGS. */ struct regcache regcache; int regcache_initted; + + /* The buffer space REGCACHE above uses. We use a separate buffer + instead of letting the regcache malloc for both signal safety and + performance reasons; this is allocated on the stack instead. */ unsigned char *regspace; + /* The register buffer passed by the client. */ unsigned char *regs; + + /* The GDB tracepoint matching the probed marker that was "hit". */ struct tracepoint *tpoint; };