From: Piotr Trojanek <trojanek@adacore.com>
Date: Mon, 5 Sep 2022 22:24:17 +0000 (+0200)
Subject: ada: Remove redundant suppression for non-modified IN OUT parameters
X-Git-Tag: basepoints/gcc-14~3476
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=dcc02d3168b4457746f6ab1d8e73cf9d15c6d4e8;p=thirdparty%2Fgcc.git

ada: Remove redundant suppression for non-modified IN OUT parameters

Non-modified IN OUT parameters are first collected and then filtered by
examining uses of their enclosing subprograms. In this filtering we
don't need to look again at properties of the formal parameters
themselves.

Cleanup related to improved detection of references to uninitialized
objects; semantics is unaffected.

gcc/ada/

	* sem_warn.adb
	(No_Warn_On_In_Out): For subprograms we can simply call
	Warnings_Off.
	(Output_Non_Modified_In_Out_Warnings): Remove repeated
	suppression.
---

diff --git a/gcc/ada/sem_warn.adb b/gcc/ada/sem_warn.adb
index 4552d907bac0..1bfa8449ad76 100644
--- a/gcc/ada/sem_warn.adb
+++ b/gcc/ada/sem_warn.adb
@@ -3006,9 +3006,9 @@ package body Sem_Warn is
          then
             return True;
 
-         --  Else test warnings off
+         --  Else test warnings off on the subprogram
 
-         elsif Warnings_Off_Check_Spec (S) then
+         elsif Warnings_Off (S) then
             return True;
 
          --  All tests for suppressing warning failed
@@ -3029,11 +3029,9 @@ package body Sem_Warn is
 
          begin
             --  Suppress warning in specific cases (see details in comments for
-            --  No_Warn_On_In_Out), or if there is a pragma Unmodified.
+            --  No_Warn_On_In_Out).
 
-            if Has_Pragma_Unmodified_Check_Spec (E1)
-              or else No_Warn_On_In_Out (E1)
-            then
+            if No_Warn_On_In_Out (E1) then
                null;
 
             --  Here we generate the warning