From: Willy Tarreau <w@1wt.eu>
Date: Wed, 8 May 2013 16:09:54 +0000 (+0200)
Subject: BUG/MINOR: acl: fix a double free during exit when using PCRE_JIT
X-Git-Tag: v1.5-dev19~40
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=dd11293e849a30ff0a72b1cfed804f238ef536cb;p=thirdparty%2Fhaproxy.git

BUG/MINOR: acl: fix a double free during exit when using PCRE_JIT

When freeing ACL regex, we don't want to perform the free() in regex_free()
as it's already performed in free_pattern(). The double free only happens
when using PCRE_JIT when freeing everything during exit so it's harmless
but exhibits libc errors during a reload/restart.

Bug reported by Seri.
---

diff --git a/include/common/regex.h b/include/common/regex.h
index bab1a55cc9..01040195a1 100644
--- a/include/common/regex.h
+++ b/include/common/regex.h
@@ -79,7 +79,6 @@ static inline void regex_free(regex *preg) {
 #ifdef USE_PCRE_JIT
 	pcre_free_study(preg->extra);
 	pcre_free(preg->reg);
-	free(preg);
 #else
 	regfree(preg);
 #endif