From: Phil Sutter <phil@nwl.cc>
Date: Wed, 22 Nov 2023 02:54:24 +0000 (+0100)
Subject: xshared: Drop needless assignment in --help case
X-Git-Tag: v1.8.11~164
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=dd38b9a85195c008cc1462e3b24c333be175efc3;p=thirdparty%2Fiptables.git

xshared: Drop needless assignment in --help case

Help text printing code does not refer to optarg, so there is no need to
assign to it if unset.

Signed-off-by: Phil Sutter <phil@nwl.cc>
---

diff --git a/iptables/xshared.c b/iptables/xshared.c
index 5f75a0a5..53e72b7a 100644
--- a/iptables/xshared.c
+++ b/iptables/xshared.c
@@ -1527,9 +1527,6 @@ void do_parse(int argc, char *argv[],
 			break;
 
 		case 'h':
-			if (!optarg)
-				optarg = argv[optind];
-
 			/* iptables -p icmp -h */
 			if (!cs->matches && cs->protocol)
 				xtables_find_match(cs->protocol,