From: Uwe Kleine-König Date: Sat, 18 Mar 2023 23:53:45 +0000 (+0100) Subject: fbdev: cg3: Convert to platform remove callback returning void X-Git-Tag: v6.4-rc1~121^2~49 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=dd65e6f3fad96150cf54f8757f71884127ec4376;p=thirdparty%2Fkernel%2Flinux.git fbdev: cg3: Convert to platform remove callback returning void The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Signed-off-by: Helge Deller --- diff --git a/drivers/video/fbdev/cg3.c b/drivers/video/fbdev/cg3.c index 3a37fff4df366..6335cd364c74c 100644 --- a/drivers/video/fbdev/cg3.c +++ b/drivers/video/fbdev/cg3.c @@ -434,7 +434,7 @@ out_err: return err; } -static int cg3_remove(struct platform_device *op) +static void cg3_remove(struct platform_device *op) { struct fb_info *info = dev_get_drvdata(&op->dev); struct cg3_par *par = info->par; @@ -446,8 +446,6 @@ static int cg3_remove(struct platform_device *op) of_iounmap(&op->resource[0], info->screen_base, info->fix.smem_len); framebuffer_release(info); - - return 0; } static const struct of_device_id cg3_match[] = { @@ -467,7 +465,7 @@ static struct platform_driver cg3_driver = { .of_match_table = cg3_match, }, .probe = cg3_probe, - .remove = cg3_remove, + .remove_new = cg3_remove, }; static int __init cg3_init(void)