From: Mike Bayer Date: Mon, 3 May 2021 19:24:48 +0000 (-0400) Subject: changelog updates X-Git-Tag: rel_1_4_13~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ddc8429689b6ca20f6afb2225ea89325d9e43c75;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git changelog updates Change-Id: Ieee55faa002cc25b3009f643e1c992180de92292 --- diff --git a/doc/build/changelog/unreleased_14/6408.rst b/doc/build/changelog/unreleased_14/6408.rst index 70653fb3b2..6dcb81c75a 100644 --- a/doc/build/changelog/unreleased_14/6408.rst +++ b/doc/build/changelog/unreleased_14/6408.rst @@ -5,19 +5,20 @@ Restored a legacy transactional behavior that was inadvertently removed from the :class:`_engine.Connection` as it was never tested as a known use case in previous versions, where calling upon the - :meth:`_engine.Connection.begin_nested` method, when no transaction were - present, would not create a SAVEPOINT at all, and would instead only start - the outermost transaction alone, and return that :class:`.RootTransaction` - object, acting like the outermost transaction. Committing the transaction - object returned by :meth:`_engine.Connection.begin_nested` would therefore - emit a real COMMIT on the database connection. + :meth:`_engine.Connection.begin_nested` method, when no transaction is + present, does not create a SAVEPOINT at all and instead starts an outer + transaction, returning a :class:`.RootTransaction` object instead of a + :class:`.NestedTransaction` object. This :class:`.RootTransaction` then + will emit a real COMMIT on the database connection when committed. + Previously, the 2.0 style behavior was present in all cases that would + autobegin a transaction but not commit it, which is a behavioral change. - This behavior is not at all what the 2.0 style connection will do - in 2.0 - style, calling :meth:`_future.Connection.begin_nested` will "autobegin" the - outer transaction, and then as instructed emit a SAVEPOINT, returning the - :class:`.NestedTransaction` object. The outer transaction is committed by - calling upon :meth:`_future.Connection.commit`, as is "commit-as-you-go" - style usage. + When using a :term:`2.0 style` connection object, the behavior is unchanged + from previous 1.4 versions; calling :meth:`_future.Connection.begin_nested` + will "autobegin" the outer transaction if not already present, and then as + instructed emit a SAVEPOINT, returning the :class:`.NestedTransaction` + object. The outer transaction is committed by calling upon + :meth:`_future.Connection.commit`, as is "commit-as-you-go" style usage. In non-"future" mode, while the old behavior is restored, it also emits a 2.0 deprecation warning as this is a legacy behavior. diff --git a/doc/build/changelog/unreleased_14/6410.rst b/doc/build/changelog/unreleased_14/6410.rst index be997c6b8c..df6b31bcda 100644 --- a/doc/build/changelog/unreleased_14/6410.rst +++ b/doc/build/changelog/unreleased_14/6410.rst @@ -5,5 +5,6 @@ Fixed regression in ``selectinload`` loader strategy that would cause it to cache its internal state incorrectly when handling relationships that join across more than one column, such as when using a composite foreign key. - The invalid caching would then cause other loader operations to fail. + The invalid caching would then cause other unrelated loader operations to + fail. diff --git a/doc/build/changelog/unreleased_14/6419_6420.rst b/doc/build/changelog/unreleased_14/6419_6420.rst index af1d4d732c..d3d60b9b1e 100644 --- a/doc/build/changelog/unreleased_14/6419_6420.rst +++ b/doc/build/changelog/unreleased_14/6419_6420.rst @@ -8,7 +8,7 @@ .. change:: :tags: bug, orm, regression - :tickets: #6420 + :tickets: 6420 Fixed regression where using the :func:`_orm.noload` loader strategy in conjunction with a "dynamic" relationship would lead to an attribute error