From: Peter Krempa <pkrempa@redhat.com>
Date: Fri, 30 Oct 2020 16:45:07 +0000 (+0100)
Subject: virCPUDefFormatBufFull: Use virXMLFormatElement
X-Git-Tag: v6.10.0-rc1~294
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=dddd442798277a317a7c042020b64fa96269f80a;p=thirdparty%2Flibvirt.git

virCPUDefFormatBufFull: Use virXMLFormatElement

The function was basically open-coding it.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c
index 7778e01131..5cf7716b12 100644
--- a/src/conf/cpu_conf.c
+++ b/src/conf/cpu_conf.c
@@ -743,21 +743,7 @@ virCPUDefFormatBufFull(virBufferPtr buf,
     if (virDomainNumaDefFormatXML(&childrenBuf, numa) < 0)
         return -1;
 
-    /* Put it all together */
-    if (virBufferUse(&attributeBuf) || virBufferUse(&childrenBuf)) {
-        virBufferAddLit(buf, "<cpu");
-
-        if (virBufferUse(&attributeBuf))
-            virBufferAddBuffer(buf, &attributeBuf);
-
-        if (virBufferUse(&childrenBuf)) {
-            virBufferAddLit(buf, ">\n");
-            virBufferAddBuffer(buf, &childrenBuf);
-            virBufferAddLit(buf, "</cpu>\n");
-        } else {
-            virBufferAddLit(buf, "/>\n");
-        }
-    }
+    virXMLFormatElement(buf, "cpu", &attributeBuf, &childrenBuf);
 
     return 0;
 }