From: Joe Hattori Date: Wed, 8 Jan 2025 01:15:37 +0000 (+0900) Subject: fbdev: omapfb: Fix an OF node leak in dss_of_port_get_parent_device() X-Git-Tag: v6.14-rc1~109^2~6 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=de124b61e179e690277116e6be512e4f422b5dd8;p=thirdparty%2Flinux.git fbdev: omapfb: Fix an OF node leak in dss_of_port_get_parent_device() dss_of_port_get_parent_device() leaks an OF node reference when i >= 2 and struct device_node *np is present. Since of_get_next_parent() obtains a reference of the returned OF node, call of_node_put() before returning NULL. This was found by an experimental verifier that I am developing, and no runtime test was able to be performed due to that lack of actual devices. Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb") Signed-off-by: Joe Hattori Reviewed-by: Laurent Pinchart Signed-off-by: Helge Deller --- diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss-of.c b/drivers/video/fbdev/omap2/omapfb/dss/dss-of.c index c04cbe0ef173d..7c636db798825 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/dss-of.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/dss-of.c @@ -36,6 +36,7 @@ struct device_node *dss_of_port_get_parent_device(struct device_node *port) np = of_get_next_parent(np); } + of_node_put(np); return NULL; }