From: Guoqing Jiang Date: Thu, 3 Jun 2021 09:21:07 +0000 (+0800) Subject: md: add comments in md_integrity_register X-Git-Tag: v5.14-rc1~127^2~2^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=de3ea66e9d23a34eef5e17f960d6473f78a1c54b;p=thirdparty%2Fkernel%2Flinux.git md: add comments in md_integrity_register Given it is not obvious for the error handling, let's try to add some comments here to make it clear. Signed-off-by: Guoqing Jiang Signed-off-by: Song Liu --- diff --git a/drivers/md/md.c b/drivers/md/md.c index 56b606184c87f..2c69905dd5c0a 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -2343,6 +2343,12 @@ int md_integrity_register(struct mddev *mddev) if (bioset_integrity_create(&mddev->bio_set, BIO_POOL_SIZE) || (mddev->level != 1 && mddev->level != 10 && bioset_integrity_create(&mddev->io_acct_set, BIO_POOL_SIZE))) { + /* + * No need to handle the failure of bioset_integrity_create, + * because the function is called by md_run() -> pers->run(), + * md_run calls bioset_exit -> bioset_integrity_free in case + * of failure case. + */ pr_err("md: failed to create integrity pool for %s\n", mdname(mddev)); return -EINVAL;