From: Andrew Burgess <aburgess@redhat.com>
Date: Fri, 14 Apr 2023 14:16:33 +0000 (+0100)
Subject: gdb: remove tracepoint_probe_create_sals_from_location_spec
X-Git-Tag: gdb-16-branchpoint~1352
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=de5dc49e43574742556868f1ba5032cbe1a0cd73;p=thirdparty%2Fbinutils-gdb.git

gdb: remove tracepoint_probe_create_sals_from_location_spec

The tracepoint_probe_create_sals_from_location_spec function just
forwards all its arguments to
bkpt_probe_create_sals_from_location_spec, and is only used in one
place.

Lets delete tracepoint_probe_create_sals_from_location_spec and
replace it with bkpt_probe_create_sals_from_location_spec.

There should be no user visible changes after this commit.
---

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index ad968c4742f..670a3f7acf7 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -283,9 +283,6 @@ static bool strace_marker_p (struct breakpoint *b);
 static void bkpt_probe_create_sals_from_location_spec
      (location_spec *locspec,
       struct linespec_result *canonical);
-static void tracepoint_probe_create_sals_from_location_spec
-     (location_spec *locspec,
-      struct linespec_result *canonical);
 
 const struct breakpoint_ops code_breakpoint_ops =
 {
@@ -300,10 +297,11 @@ static const struct breakpoint_ops bkpt_probe_breakpoint_ops =
   create_breakpoints_sal,
 };
 
-/* Tracepoints set on probes.  */
+/* Tracepoints set on probes.  We use the same methods as for breakpoints
+   on probes.  */
 static const struct breakpoint_ops tracepoint_probe_breakpoint_ops =
 {
-  tracepoint_probe_create_sals_from_location_spec,
+  bkpt_probe_create_sals_from_location_spec,
   create_breakpoints_sal,
 };
 
@@ -12405,17 +12403,6 @@ tracepoint::print_recreate (struct ui_file *fp) const
     gdb_printf (fp, "  passcount %d\n", pass_count);
 }
 
-/* Virtual table for tracepoints on static probes.  */
-
-static void
-tracepoint_probe_create_sals_from_location_spec
-  (location_spec *locspec,
-   struct linespec_result *canonical)
-{
-  /* We use the same method for breakpoint on probes.  */
-  bkpt_probe_create_sals_from_location_spec (locspec, canonical);
-}
-
 void
 dprintf_breakpoint::re_set ()
 {