From: Theodore Ts'o Date: Wed, 2 Jul 2025 02:58:39 +0000 (-0400) Subject: fuse2fs: fix normal (non-kernel) permissions checking X-Git-Tag: v1.47.3-rc3~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=de86c43faae725799d143cf763eb03500cdbf46c;p=thirdparty%2Fe2fsprogs.git fuse2fs: fix normal (non-kernel) permissions checking Commit 9f69dfc4e275 ("fuse2fs: implement O_APPEND correctly") defined a new flag, A_OK, to add support for testing whether the file is valid for append operations. This is relevant for the check_iflags_access() function, but when are later testing operations mask against the inode permissions, this new flag gets in the way and causes non-root users attempting to create new inodes in a directory to fail. Fix this by masking off A_OK before doing these tests. Fixes: 9f69dfc4e275 ("fuse2fs: implement O_APPEND correctly") Signed-off-by: Theodore Ts'o --- diff --git a/misc/fuse2fs.c b/misc/fuse2fs.c index bb75d942..d209bc79 100644 --- a/misc/fuse2fs.c +++ b/misc/fuse2fs.c @@ -687,6 +687,9 @@ static int check_inum_access(struct fuse2fs *ff, ext2_ino_t ino, int mask) return -EACCES; } + /* Remove the O_APPEND flag before testing permissions */ + mask &= ~A_OK; + /* allow owner, if perms match */ if (inode_uid(inode) == ctxt->uid) { if ((mask & (perms >> 6)) == mask)