From: Robert Haas <rhaas@postgresql.org>
Date: Fri, 28 Oct 2011 19:45:28 +0000 (-0400)
Subject: Remove hard-coded "\connect postgres" from pg_dumpall.
X-Git-Tag: REL9_2_BETA1~918
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=deb15803249883db031c6cc8af104b575f7809ad;p=thirdparty%2Fpostgresql.git

Remove hard-coded "\connect postgres" from pg_dumpall.

This doesn't appear to accompish anything useful, and does make the
restore fail if the postgres database happens to have been dropped.
---

diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c
index 0022d2d74ef..d138da568ea 100644
--- a/src/bin/pg_dump/pg_dumpall.c
+++ b/src/bin/pg_dump/pg_dumpall.c
@@ -441,7 +441,12 @@ main(int argc, char *argv[])
 	if (verbose)
 		dumpTimestamp("Started on");
 
-	fprintf(OPF, "\\connect postgres\n\n");
+	/*
+	 * We used to emit \connect postgres here, but that served no purpose
+	 * other than to break things for installations without a postgres
+	 * database.  Everything we're restoring here is a global, so whichever
+	 * database we're connected to at the moment is fine.
+	 */
 
 	/* Replicate encoding and std_strings in output */
 	fprintf(OPF, "SET client_encoding = '%s';\n",