From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
Date: Tue, 10 Dec 2024 02:33:48 +0000 (-0800)
Subject: gprofng: fix sorting in Hist_data::sort
X-Git-Tag: gdb-16-branchpoint~136
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ded4c0a10e93235f19e967551a717d9348ebb1d9;p=thirdparty%2Fbinutils-gdb.git

gprofng: fix sorting in Hist_data::sort

If the '-name soname' option is used, the fake '<Total>' function is expanded
with the name loadobject.

gprofng/ChangeLog
2024-12-09  Vladimir Mezentsev  <vladimir.mezentsev@oracle.com>

	* src/Hist_data.cc (Hist_data::sort): Fix sorting.
---

diff --git a/gprofng/src/Hist_data.cc b/gprofng/src/Hist_data.cc
index fb729018e0a..35d1f866a82 100644
--- a/gprofng/src/Hist_data.cc
+++ b/gprofng/src/Hist_data.cc
@@ -521,12 +521,11 @@ Hist_data::sort (long ind, bool reverse)
     hist_items->sort ((CompareFunc) sort_compare_all, this);
 
   // ensure that <Total> comes first/last
-  char *tname = NTXT ("<Total>");
   for (int i = 0; i < hist_items->size (); ++i)
     {
       HistItem *hi = hist_items->fetch (i);
       char *name = hi->obj->get_name ();
-      if (name != NULL && streq (name, tname))
+      if (name != NULL && strncmp (name, "<Total>", 7) == 0)
 	{
 	  int idx0 = rev_sort ? hist_items->size () - 1 : 0;
 	  if (i != idx0)