From: Junio C Hamano Date: Thu, 16 Dec 2021 23:37:10 +0000 (-0800) Subject: format-patch: mark rev_info with UNLEAK X-Git-Tag: v2.35.0-rc0~48^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=dee839a2633;p=thirdparty%2Fgit.git format-patch: mark rev_info with UNLEAK The comand uses a single instance of rev_info on stack, makes a single revision traversal and exit. Mark the resources held by the rev_info structure with UNLEAK(). We do not do this at lower level in revision.c or cmd_log_walk(), as a new caller of the revision traversal API can make unbounded number of rev_info during a single run, and UNLEAK() would not a be suitable mechanism to deal with such a caller. Signed-off-by: Junio C Hamano --- diff --git a/builtin/log.c b/builtin/log.c index f75d87e8d7..a7bca8353b 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -2241,6 +2241,7 @@ done: strbuf_release(&rdiff1); strbuf_release(&rdiff2); strbuf_release(&rdiff_title); + UNLEAK(rev); return 0; }