From: Joe Orton <jorton@apache.org>
Date: Fri, 10 Dec 2021 14:50:19 +0000 (+0000)
Subject: * modules/ssl/ssl_engine_io.c (bio_filter_in_ctrl): Remove debugging
X-Git-Tag: 2.5.0-alpha2-ci-test-only~653
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=df5ca407a6ac569e91e5e078c96acbd1edc0dd52;p=thirdparty%2Fapache%2Fhttpd.git

* modules/ssl/ssl_engine_io.c (bio_filter_in_ctrl): Remove debugging
  assert for unexpected control commands, matching bio_filter_out_ctrl
  which also ignores such invocations.  Fixes core dumps in debug
  builds with OpenSSL 3.0.0 which triggers this via the
  BIO_get_ktls_recv() call on the SSL bio, aka
    BIO_ctrl(b, BIO_CTRL_GET_KTLS_RECV, ...);

See: https://github.com/openssl/openssl/blob/105af0ad923a665ca5fee296b52dbf34b524a2aa/ssl/record/rec_layer_s3.c#L274


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1895774 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/ssl/ssl_engine_io.c b/modules/ssl/ssl_engine_io.c
index 348956079a2..7f2386fb115 100644
--- a/modules/ssl/ssl_engine_io.c
+++ b/modules/ssl/ssl_engine_io.c
@@ -627,7 +627,6 @@ static long bio_filter_in_ctrl(BIO *bio, int cmd, long num, void *ptr)
     ap_log_cerror(APLOG_MARK, APLOG_TRACE1, 0, inctx->f->c,
                   "BUG: bio_filter_in_ctrl() should not be called with cmd=%i",
                   cmd);
-    AP_DEBUG_ASSERT(0);
     return 0;
 }