From: Peter Eisentraut <peter@eisentraut.org>
Date: Thu, 29 Jun 2023 08:30:55 +0000 (+0200)
Subject: Remove inappropriate raw_expression_tree_walker() code
X-Git-Tag: REL_15_4~52
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=df5dcf41cf01af158d2b833a0ae752e52f5d38e8;p=thirdparty%2Fpostgresql.git

Remove inappropriate raw_expression_tree_walker() code

It was walking into the ColumnDef->compression field, which is not a
node but a string.  This code is currently not reachable (because the
compression field is only set in situations that don't go through
raw_expression_tree_walker()), but if it had been, this could have
behaved erratically.
---

diff --git a/src/backend/nodes/nodeFuncs.c b/src/backend/nodes/nodeFuncs.c
index 6029da3ee1f..a7080f5cb24 100644
--- a/src/backend/nodes/nodeFuncs.c
+++ b/src/backend/nodes/nodeFuncs.c
@@ -4011,8 +4011,6 @@ raw_expression_tree_walker(Node *node,
 
 				if (walker(coldef->typeName, context))
 					return true;
-				if (walker(coldef->compression, context))
-					return true;
 				if (walker(coldef->raw_default, context))
 					return true;
 				if (walker(coldef->collClause, context))