From: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Date: Wed, 21 May 2025 01:08:56 +0000 (+1200)
Subject: s4:dsdb: Use PyLong_FromUnsignedLong() for unsigned values
X-Git-Tag: tevent-0.17.0~129
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=df719a28f179e4da6f9de58304bc6348e001632e;p=thirdparty%2Fsamba.git

s4:dsdb: Use PyLong_FromUnsignedLong() for unsigned values

Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
---

diff --git a/source4/dsdb/pydsdb.c b/source4/dsdb/pydsdb.c
index e3ebd3f4349..cae423900cc 100644
--- a/source4/dsdb/pydsdb.c
+++ b/source4/dsdb/pydsdb.c
@@ -343,7 +343,7 @@ static PyObject *py_dsdb_get_searchFlags_from_lDAPDisplayName(PyObject *self, Py
 		return NULL;
 	}
 
-	return PyLong_FromLong(attribute->searchFlags);
+	return PyLong_FromUnsignedLong(attribute->searchFlags);
 }
 
 /*
@@ -375,7 +375,7 @@ static PyObject *py_dsdb_get_systemFlags_from_lDAPDisplayName(PyObject *self, Py
 		return NULL;
 	}
 
-	return PyLong_FromLong(attribute->systemFlags);
+	return PyLong_FromUnsignedLong(attribute->systemFlags);
 }
 
 /*
@@ -407,7 +407,7 @@ static PyObject *py_dsdb_get_linkId_from_lDAPDisplayName(PyObject *self, PyObjec
 		return NULL;
 	}
 
-	return PyLong_FromLong(attribute->linkID);
+	return PyLong_FromUnsignedLong(attribute->linkID);
 }
 
 /*
@@ -1291,7 +1291,7 @@ static PyObject *py_dsdb_allocate_rid(PyObject *self, PyObject *args)
 	TALLOC_FREE(rid_return);
 	TALLOC_FREE(ext_res);
 
-	return PyLong_FromLong(rid);
+	return PyLong_FromUnsignedLong(rid);
 }
 
 #ifdef AD_DC_BUILD_IS_ENABLED
@@ -1842,7 +1842,7 @@ MODULE_INIT_FUNC(dsdb)
 	if (m == NULL)
 		return NULL;
 
-#define ADD_DSDB_FLAG(val)  PyModule_AddObject(m, #val, PyLong_FromLong(val))
+#define ADD_DSDB_FLAG(val)  PyModule_AddObject(m, #val, PyLong_FromUnsignedLong(val))
 
 	/* "userAccountControl" flags */
 	ADD_DSDB_FLAG(UF_NORMAL_ACCOUNT);