From: Pieter Lexis <pieter.lexis@powerdns.com>
Date: Thu, 3 Jan 2019 08:50:26 +0000 (+0100)
Subject: Improve error on sending non-TC resp that should be TC
X-Git-Tag: rec-4.2.0-alpha1~67^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=dfa4c4a6428df720e32a68db405fcfa01ec1a51e;p=thirdparty%2Fpdns.git

Improve error on sending non-TC resp that should be TC

This should aid in debugging when this happens.
---

diff --git a/pdns/nameserver.cc b/pdns/nameserver.cc
index 3ce54d92f6..64757705ec 100644
--- a/pdns/nameserver.cc
+++ b/pdns/nameserver.cc
@@ -297,7 +297,7 @@ void UDPNameserver::send(DNSPacket *p)
   }
   DLOG(g_log<<Logger::Notice<<"Sending a packet to "<< p->getRemote() <<" ("<< buffer.length()<<" octets)"<<endl);
   if(buffer.length() > p->getMaxReplyLen()) {
-    g_log<<Logger::Error<<"Weird, trying to send a message that needs truncation, "<< buffer.length()<<" > "<<p->getMaxReplyLen()<<endl;
+    g_log<<Logger::Error<<"Weird, trying to send a message that needs truncation, "<< buffer.length()<<" > "<<p->getMaxReplyLen()<<". Question was for "<<p->qdomain<<"|"<<p->qtype.getName()<<endl;
   }
   if(sendmsg(p->getSocket(), &msgh, 0) < 0)
     g_log<<Logger::Error<<"Error sending reply with sendmsg (socket="<<p->getSocket()<<", dest="<<p->d_remote.toStringWithPort()<<"): "<<strerror(errno)<<endl;