From: Christian Brauner <brauner@kernel.org>
Date: Mon, 25 Nov 2024 14:10:11 +0000 (+0100)
Subject: nfs/nfs4recover: avoid pointless cred reference count bump
X-Git-Tag: v6.14-rc1~214^2~1^2~14
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=dfce6a462a9490063852c5d91d0f41104c0aad6d;p=thirdparty%2Flinux.git

nfs/nfs4recover: avoid pointless cred reference count bump

The code already got rid of the extra reference count from the old
version of override_creds().

Link: https://lore.kernel.org/r/20241125-work-cred-v2-15-68b9d38bb5b2@kernel.org
Acked-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Christian Brauner <brauner@kernel.org>
---

diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
index f3837167b6a14..7f2ceeb118a42 100644
--- a/fs/nfsd/nfs4recover.c
+++ b/fs/nfsd/nfs4recover.c
@@ -81,8 +81,7 @@ nfs4_save_creds(const struct cred **original_creds)
 
 	new->fsuid = GLOBAL_ROOT_UID;
 	new->fsgid = GLOBAL_ROOT_GID;
-	*original_creds = override_creds(get_new_cred(new));
-	put_cred(new);
+	*original_creds = override_creds(new);
 	return 0;
 }