From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 1 Dec 2020 07:04:12 +0000 (-0800)
Subject: 9p: Uninitialized variable in v9fs_writeback_fid()
X-Git-Tag: v5.11-rc1~46^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=dfd375864ac1e2ee60ed2d61820697ac01642f80;p=thirdparty%2Flinux.git

9p: Uninitialized variable in v9fs_writeback_fid()

If v9fs_fid_lookup_with_uid() fails then "fid" is not initialized.

The v9fs_fid_lookup_with_uid() can't return NULL.  If it returns an
error pointer then we can still pass that to clone_fid() and it will
return the error pointer back again.

Fixes: 6636b6dcc3db ("9p: add refcount to p9_fid struct")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
---

diff --git a/fs/9p/fid.c b/fs/9p/fid.c
index 50118ec72a926..79837f1b1c913 100644
--- a/fs/9p/fid.c
+++ b/fs/9p/fid.c
@@ -302,8 +302,7 @@ struct p9_fid *v9fs_writeback_fid(struct dentry *dentry)
 	struct p9_fid *fid, *ofid;
 
 	ofid = v9fs_fid_lookup_with_uid(dentry, GLOBAL_ROOT_UID, 0);
-	if (ofid && !IS_ERR(ofid))
-		fid = clone_fid(ofid);
+	fid = clone_fid(ofid);
 	if (IS_ERR(fid))
 		goto error_out;
 	p9_client_clunk(ofid);