From: Stephan Bosch <stephan.bosch@open-xchange.com>
Date: Sun, 18 Aug 2024 00:42:10 +0000 (+0200)
Subject: lib-smtp: smtp-server-connection - Move common connection creation code to separate... 
X-Git-Tag: 2.4.0~192
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=dff3cc42dd49b4a1f0f9e13f77979bbb6c04fd7b;p=thirdparty%2Fdovecot%2Fcore.git

lib-smtp: smtp-server-connection - Move common connection creation code to separate function
---

diff --git a/src/lib-smtp/smtp-server-connection.c b/src/lib-smtp/smtp-server-connection.c
index 9203abf597..3a27207136 100644
--- a/src/lib-smtp/smtp-server-connection.c
+++ b/src/lib-smtp/smtp-server-connection.c
@@ -1020,6 +1020,14 @@ smtp_server_connection_alloc(struct smtp_server *server,
 	return conn;
 }
 
+static void smtp_server_connection_created(struct smtp_server_connection *conn)
+{
+	/* Halt input until started */
+	smtp_server_connection_halt(conn);
+
+	e_debug(conn->event, "Connection created");
+}
+
 struct smtp_server_connection *
 smtp_server_connection_create(
 	struct smtp_server *server, int fd_in, int fd_out,
@@ -1044,10 +1052,7 @@ smtp_server_connection_create(
 	if (ssl_start)
 		conn->set.capabilities &= ENUM_NEGATE(SMTP_CAPABILITY_STARTTLS);
 
-	/* Halt input until started */
-	smtp_server_connection_halt(conn);
-
-	e_debug(conn->event, "Connection created");
+	smtp_server_connection_created(conn);
 
 	return conn;
 }
@@ -1084,10 +1089,7 @@ smtp_server_connection_create_from_streams(
 	smtp_server_connection_update_event(conn);
 	event_unref(&conn_event);
 
-	/* Halt input until started */
-	smtp_server_connection_halt(conn);
-
-	e_debug(conn->event, "Connection created");
+	smtp_server_connection_created(conn);
 
 	return conn;
 }