From: Vincent Bernat <vincent@bernat.im>
Date: Tue, 29 Dec 2015 13:47:04 +0000 (+0100)
Subject: client: don't do arithmetics with void*
X-Git-Tag: 0.9.0~10
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=dff59172ab55749de7859772f1ed67fec41fc5fd;p=thirdparty%2Flldpd.git

client: don't do arithmetics with void*

It's illegal.
---

diff --git a/configure.ac b/configure.ac
index d3bf3c13..3f7dd0ce 100644
--- a/configure.ac
+++ b/configure.ac
@@ -82,6 +82,7 @@ AX_CFLAGS_GCC_OPTION([-Wcast-align], [LLDP_CFLAGS])
 AX_CFLAGS_GCC_OPTION([-Wheader-guard], [LLDP_CFLAGS])
 AX_CFLAGS_GCC_OPTION([-Wdocumentation], [LLDP_CFLAGS])
 AX_CFLAGS_GCC_OPTION([-Winline], [LLDP_CFLAGS])
+AX_CFLAGS_GCC_OPTION([-Wpointer-arith], [LLDP_CFLAGS])
 AX_CFLAGS_GCC_OPTION([-fno-omit-frame-pointer], [LLDP_CFLAGS])
 AX_CFLAGS_GCC_OPTION([-Wno-unused-parameter], [LLDP_CFLAGS])
 AX_CFLAGS_GCC_OPTION([-Wno-missing-field-initializers], [LLDP_CFLAGS])
diff --git a/src/lib/connection.c b/src/lib/connection.c
index aeb702e5..591d9e94 100644
--- a/src/lib/connection.c
+++ b/src/lib/connection.c
@@ -77,7 +77,7 @@ sync_recv(lldpctl_conn_t *lldpctl,
 
 	remain = length;
 	do {
-		if ((nb = read(conn->fd, (void*)data + offset, remain)) == -1) {
+		if ((nb = read(conn->fd, (unsigned char*)data + offset, remain)) == -1) {
 			if (errno == EAGAIN || errno == EINTR)
 				continue;
 			return LLDPCTL_ERR_CALLBACK_FAILURE;