From: sergey.kitov <sergey.kitov@open-xchange.com>
Date: Wed, 4 Oct 2023 12:30:37 +0000 (+0300)
Subject: pop3: change pop3_client_workarounds to BOOLLIST.
X-Git-Tag: 2.4.0~594
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e0fef88282842da5b0defb42d6dee657a056b3cd;p=thirdparty%2Fdovecot%2Fcore.git

pop3: change pop3_client_workarounds to BOOLLIST.
---

diff --git a/src/pop3/pop3-settings.c b/src/pop3/pop3-settings.c
index 114e618b29..ad96050b37 100644
--- a/src/pop3/pop3-settings.c
+++ b/src/pop3/pop3-settings.c
@@ -61,7 +61,7 @@ static const struct setting_define pop3_setting_defines[] = {
 	DEF(BOOL, pop3_save_uidl),
 	DEF(BOOL, pop3_lock_session),
 	DEF(BOOL, pop3_fast_size_lookups),
-	DEF(STR, pop3_client_workarounds),
+	DEF(BOOLLIST, pop3_client_workarounds),
 	DEF(STR_NOVARS, pop3_logout_format),
 	DEF(ENUM, pop3_uidl_duplicates),
 	DEF(STR, pop3_deleted_flag),
@@ -80,7 +80,7 @@ static const struct pop3_settings pop3_default_settings = {
 	.pop3_save_uidl = FALSE,
 	.pop3_lock_session = FALSE,
 	.pop3_fast_size_lookups = FALSE,
-	.pop3_client_workarounds = "",
+	.pop3_client_workarounds = ARRAY_INIT,
 	.pop3_logout_format = "top=%t/%p, retr=%r/%b, del=%d/%m, size=%s",
 	.pop3_uidl_duplicates = "allow:rename",
 	.pop3_deleted_flag = "",
@@ -118,7 +118,7 @@ pop3_settings_parse_workarounds(struct pop3_settings *set,
 	const struct pop3_client_workaround_list *list;
 	const char *const *str;
 
-        str = t_strsplit_spaces(set->pop3_client_workarounds, " ,");
+	str = settings_boollist_get(&set->pop3_client_workarounds);
 	for (; *str != NULL; str++) {
 		list = pop3_client_workaround_list;
 		for (; list->name != NULL; list++) {
diff --git a/src/pop3/pop3-settings.h b/src/pop3/pop3-settings.h
index 91fe88bad6..adb4244e3f 100644
--- a/src/pop3/pop3-settings.h
+++ b/src/pop3/pop3-settings.h
@@ -26,7 +26,7 @@ struct pop3_settings {
 	bool pop3_save_uidl;
 	bool pop3_lock_session;
 	bool pop3_fast_size_lookups;
-	const char *pop3_client_workarounds;
+	ARRAY_TYPE(const_string) pop3_client_workarounds;
 	const char *pop3_logout_format;
 	const char *pop3_uidl_duplicates;
 	const char *pop3_deleted_flag;