From: Uwe Kleine-König Date: Wed, 4 May 2022 18:31:31 +0000 (+0200) Subject: leds: is31fl32xx: Improve error reporting in .remove() X-Git-Tag: v5.19-rc1~87^2~6 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e1347bd4abfb3eaee8bbdc9089b64b249a7639b6;p=thirdparty%2Fkernel%2Flinux.git leds: is31fl32xx: Improve error reporting in .remove() Returning an error value in an i2c remove callback results in a generic error message being emitted by the i2c core, but otherwise it doesn't make a difference. The device goes away anyhow and the devm cleanups are called. So instead of triggering the generic i2c error message, emit a more helpful message if a problem occurs and return 0 to suppress the generic message. This patch is a preparation for making i2c remove callbacks return void. Signed-off-by: Uwe Kleine-König Signed-off-by: Pavel Machek --- diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c index 22c092a4394ab..fc63fce38c196 100644 --- a/drivers/leds/leds-is31fl32xx.c +++ b/drivers/leds/leds-is31fl32xx.c @@ -460,8 +460,14 @@ static int is31fl32xx_probe(struct i2c_client *client, static int is31fl32xx_remove(struct i2c_client *client) { struct is31fl32xx_priv *priv = i2c_get_clientdata(client); + int ret; - return is31fl32xx_reset_regs(priv); + ret = is31fl32xx_reset_regs(priv); + if (ret) + dev_err(&client->dev, "Failed to reset registers on removal (%pe)\n", + ERR_PTR(ret)); + + return 0; } /*